mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 52943: Updated CLI pylint configuration to disable no-self-use warnings.
Date Tue, 18 Oct 2016 01:00:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52943/#review153005
-----------------------------------------------------------


Ship it!




I see this warning here: 
https://reviews.apache.org/r/52950/
Which seems valid in that context.

Another warning here:
https://reviews.apache.org/r/52952/
That one seems ok to disable the warning.

Lots of warnings in:
https://reviews.apache.org/r/52953/

Considering the potential (unnecessary) code churn from switching back and forth between `@classmethod`
and not-`@classmethod`, disabling this one seems ok.

- Joseph Wu


On Oct. 17, 2016, 1:11 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52943/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2016, 1:11 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5676
>     https://issues.apache.org/jira/browse/MESOS-5676
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated CLI pylint configuration to disable no-self-use warnings.
> 
> 
> Diffs
> -----
> 
>   src/cli_new/pylint.config c398220db063d249e6c62cf7e8cd6757e7860630 
> 
> Diff: https://reviews.apache.org/r/52943/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message