mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 52786: Add the health check test helper.
Date Fri, 21 Oct 2016 10:11:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52786/#review153520
-----------------------------------------------------------



I applied this patch on top of master and the tests don't compile anymore =(.

```
[17:59:17]W:	 [Step 7/10] ../../src/tests/containerizer/health_check_test_helper.cpp: In constructor
‘mesos::internal::tests::HealthCheckTestHelper::Flags::Flags()’:
[17:59:17]W:	 [Step 7/10] ../../src/tests/containerizer/health_check_test_helper.cpp:53:33:
error: no matching function for call to ‘mesos::internal::tests::HealthCheckTestHelper::Flags::add(std::string*,
const char [3], const char [25])’
[17:59:17]W:	 [Step 7/10]        "IP address to listen on.");
[17:59:17]W:	 [Step 7/10]                                  ^
```

- Gastón Kleiman


On Oct. 17, 2016, 2:51 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52786/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2016, 2:51 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Gastón Kleiman.
> 
> 
> Bugs: MESOS-6278
>     https://issues.apache.org/jira/browse/MESOS-6278
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the test helper for the health check. Via starts a
> simple HTTP server which listens on given IP and port, it makes testing
> HTTP health check and TCP health check easier.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 3bcc0f2dfc2c4f71841bd6d161f39e0e919fc0d7 
>   src/tests/CMakeLists.txt f5d66dc63143455506d8660674fbd9eb227625ff 
>   src/tests/containerizer/health_check_test_helper.hpp PRE-CREATION 
>   src/tests/containerizer/health_check_test_helper.cpp PRE-CREATION 
>   src/tests/test_helper_main.cpp 129a5e427b72fb577e55c3756d071f72ced9ff14 
> 
> Diff: https://reviews.apache.org/r/52786/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message