mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 52879: Cleaned up the way in which the executors load configuration options.
Date Fri, 21 Oct 2016 11:46:29 GMT


> On Oct. 17, 2016, 8:08 p.m., Jie Yu wrote:
> > src/launcher/default_executor.cpp, lines 1015-1042
> > <https://reviews.apache.org/r/52879/diff/1/?file=1538032#file1538032line1015>
> >
> >     Thanks for doing that! This definitely simplies the parsing of those env variables.
> >     
> >     I think there are two types of flags (or ENV) that'll be passed to default executor
(and this also applies to the old command executor):
> >     
> >     1) executor environment variables that are *COMMON* to all executors, including
custom executors. For instance, MESOS_EXECUTOR_ID, MESOS_FRAMEWORK_ID, MESOS_SANDBOX.
> >     
> >     2) flags or env variables that only apply to default executor (or old command
executor). For instance, `launcher_dir`, `MESOS_HTTP_COMMAND_EXECUTOR`. In retrospect, we
probably should do the following for command executor:
> >     ```
> >     COMMAND_EXECUTOR_HTTP_API
> >     COMMAND_EXECUTOR_LAUNCHER_DIR
> >     ```
> >     
> >     and in command executor, we probably need two sets of flags:
> >     ```
> >     MesosFlags mesosFlags; // MESOS_*
> >     CommandExecutorFlags commandExecutorFlags; // COMMAND_EXECUTOR_*
> >     ```
> >     
> >     cc @vinodkone @anand

I created `mesos::v1::executor::Flags`, which handle the flags common to all executors.

Then I updated the flags handling in all the executors, the executor driver and the v1 executor
library. Most of them now use their own `Flags` class, which inherits from `mesos::v1::executor::Flags`.


> On Oct. 17, 2016, 8:08 p.m., Jie Yu wrote:
> > src/launcher/default_executor.cpp, line 1028
> > <https://reviews.apache.org/r/52879/diff/1/?file=1538032#file1538032line1028>
> >
> >     What's this? Is this MESOS_SANDBOX?

Yes, I moved this flag to `mesos::v1::executor::Flags`.


> On Oct. 17, 2016, 8:08 p.m., Jie Yu wrote:
> > src/launcher/default_executor.cpp, lines 1066-1069
> > <https://reviews.apache.org/r/52879/diff/1/?file=1538032#file1538032line1066>
> >
> >     I thought we should start to use `LIBPROCESS_SSL_xxx`

Fixed in https://reviews.apache.org/r/53084/.


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52879/#review152940
-----------------------------------------------------------


On Oct. 21, 2016, 11:38 a.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52879/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2016, 11:38 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, Jie Yu,
and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated the executors so that they use only `stout::flags` to load
> config options.
> 
> They used to use a mix of `stout::flags` and `os::getenv`.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt e60d34ca4b714bb237d5864b4682280f11b147a6 
>   src/Makefile.am 05fe8fa3e3409b35ba66d7e7238e988fb0fab07d 
>   src/common/parse.hpp ee26717ed54445f57fa3a11c74ece8fe0861bd40 
>   src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6 
>   src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 
>   src/exec/exec.cpp 1dc20390907253a466b7272b7f8b33ea14afb236 
>   src/exec/flags.hpp PRE-CREATION 
>   src/exec/flags.cpp PRE-CREATION 
>   src/executor/executor.cpp 1d47b52d89eedee59d160badd6313d34e3bdb6d2 
>   src/executor/flags.hpp PRE-CREATION 
>   src/executor/flags.cpp PRE-CREATION 
>   src/launcher/default_executor.cpp af4a97f7de5f2157aa65fdab742455b0683c40a4 
>   src/launcher/executor.hpp 217680d99d6e8c31130d7dc714f8cd730f360852 
>   src/launcher/executor.cpp 0544121e679db503fe4eaf23a24e315eb188a520 
>   src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 
>   src/tests/containerizer.cpp 69b93c70dc883e1edff3e6c2d7c8da9ef05e42f8 
> 
> Diff: https://reviews.apache.org/r/52879/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message