mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 53124: Add documentation on Windows support
Date Fri, 28 Oct 2016 20:49:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53124/#review154174
-----------------------------------------------------------



Also consider watching this:
https://www.youtube.com/watch?v=bbyK1EBxrek&index=27&list=PLGeM09tlguZQVL7ZsfNMffX9h1rGNVqnC

Many of the limitations discussed there are still applicable.


docs/windows.md (line 8)
<https://reviews.apache.org/r/53124/#comment223663>

    Considering how different the two getting-started pages are (lots of manual steps), I'd
actually like to move the content over here.  You can leave a link in the getting-started
page to this file.



docs/windows.md (line 12)
<https://reviews.apache.org/r/53124/#comment223662>

    Nit: s/Linux/Posix/



docs/windows.md (line 13)
<https://reviews.apache.org/r/53124/#comment223661>

    Micro-nit: s/launcher_dir/--launcher_dir/
    
    And backticks around `MAX_PATH`



docs/windows.md (line 14)
<https://reviews.apache.org/r/53124/#comment223664>

    Technically, this is due to Marathon appending a UUID (36 characters) onto the TaskID.
 So an ID of < 40 characters is still possible.


- Joseph Wu


On Oct. 23, 2016, 3:09 p.m., Lior Zeno wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53124/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2016, 3:09 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Alex Clemmer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds documentation on Windows support in Mesos.
> Currently considered a WIP, published in order to receive inital feedback.
> 
> 
> Diffs
> -----
> 
>   docs/home.md f47f7f9 
>   docs/windows.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53124/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lior Zeno
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message