mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 53266: Refactored `DefaultExecutorTest.ROOT_TaskRunning` [1/3].
Date Mon, 31 Oct 2016 16:08:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53266/
-----------------------------------------------------------

(Updated Oct. 31, 2016, 4:08 p.m.)


Review request for mesos, Till Toenshoff and Jiang Yan Xu.


Changes
-------

I split the patch in 3 smaller chunks, one for each test.

Now all tests run with the Mesos containerizer, requiring neither root nor Docker. They also
run with the Docker containerizer, requiring both root and Docker.

Semi-off-topic question: does the Docker containerizer require both Docker AND root? Will
it not work if launched as a regular user with access to the Docker unix socket and binary?


Summary (updated)
-----------------

Refactored `DefaultExecutorTest.ROOT_TaskRunning` [1/3].


Bugs: MESOS-6455
    https://issues.apache.org/jira/browse/MESOS-6455


Repository: mesos


Description (updated)
-------

This test is parameterized, making it run with both the Docker and the
Mesos containerizers.

The test name doesn't contain `DOCKER_,` so the test instantiation that
uses the Docker containerizer will run and fail if Docker is not
available.

Because the test name starts with `ROOT_`, it only runs if root tests
are not filtered, but root by the Mesos containerizer.

I moved moved the body of the test into a fixture method, so that I
could split `ROOT_TaskRunning` into `TaskRunning` and
`ROOT_DOCKER_TaskRunning`.


Diffs (updated)
-----

  src/tests/default_executor_tests.cpp 70779e8d94fbb6e664cad4ddbfeb19e560176cfe 

Diff: https://reviews.apache.org/r/53266/diff/


Testing
-------

`sudo bin/mesos-tests.sh --gtest_filter=DefaultExecutorTest.* --docker=/tmp/foo`
`sudo bin/mesos-tests.sh --gtest_filter=DefaultExecutorTest.*`


Thanks,

Gastón Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message