Gastón Kleiman |
Re: Review Request 52357: Improved handling of health check failures within the grace period. |
Tue, 04 Oct, 13:18 |
Gastón Kleiman |
Re: Review Request 52434: Improved handling of tmp file creation in health check test. |
Tue, 04 Oct, 13:40 |
Gastón Kleiman |
Re: Review Request 52434: Improved handling of tmp file creation in health check test. |
Tue, 04 Oct, 16:14 |
Gastón Kleiman |
Re: Review Request 52432: Updated and reenabled 'HealthCheckTest.GracePeriod'. |
Wed, 05 Oct, 12:37 |
Gastón Kleiman |
Re: Review Request 52432: Updated and reenabled 'HealthCheckTest.GracePeriod'. |
Wed, 05 Oct, 12:42 |
Gastón Kleiman |
Re: Review Request 52433: Improved the naming of variables in HealthCheckTest.HealthStatusChange. |
Wed, 05 Oct, 12:46 |
Gastón Kleiman |
Re: Review Request 52434: Improved handling of tmp file creation in health check test. |
Wed, 05 Oct, 12:47 |
Gastón Kleiman |
Re: Review Request 52432: Updated and reenabled 'HealthCheckTest.GracePeriod'. |
Wed, 05 Oct, 13:00 |
Gastón Kleiman |
Re: Review Request 52432: Updated and reenabled 'HealthCheckTest.GracePeriod'. |
Wed, 05 Oct, 14:10 |
Gastón Kleiman |
Re: Review Request 52431: Reduced boilerplate from health check tests. |
Wed, 05 Oct, 14:35 |
Gastón Kleiman |
Re: Review Request 52433: Improved the naming of variables in HealthCheckTest.HealthStatusChange. |
Wed, 05 Oct, 14:37 |
Gastón Kleiman |
Re: Review Request 52563: Minor clean ups in `health_check_tests.cpp` for consistency. |
Thu, 06 Oct, 13:09 |
Gastón Kleiman |
Re: Review Request 52560: Avoided temporary `MockDocker` pointers in health check test cases. |
Thu, 06 Oct, 13:11 |
Gastón Kleiman |
Re: Review Request 52561: Renamed `flags` to `agentFlags` in health check test cases. |
Thu, 06 Oct, 13:12 |
Gastón Kleiman |
Re: Review Request 52556: Added the MESOS_RUNTIME_DIRECTORY executor env variable. |
Thu, 06 Oct, 16:28 |
Gastón Kleiman |
Review Request 52608: Reordered the list of executor env variables in code and documentation. |
Thu, 06 Oct, 16:29 |
Gastón Kleiman |
Re: Review Request 52556: Added the MESOS_RUNTIME_DIRECTORY executor env variable. |
Thu, 06 Oct, 16:33 |
Gastón Kleiman |
Review Request 52628: Fixed typo in headers. |
Fri, 07 Oct, 12:54 |
Gastón Kleiman |
Re: Review Request 52628: Fixed typos in resources.hpp headers. |
Fri, 07 Oct, 12:57 |
Gastón Kleiman |
Review Request 52642: Improved the validation of RESERVE operations. |
Fri, 07 Oct, 18:00 |
Gastón Kleiman |
Re: Review Request 52556: Added the MESOS_RUNTIME_DIRECTORY executor env variable. |
Mon, 10 Oct, 16:20 |
Gastón Kleiman |
Re: Review Request 52556: Added the MESOS_RUNTIME_DIRECTORY executor env variable. |
Tue, 11 Oct, 18:52 |
Gastón Kleiman |
Re: Review Request 52608: Reordered the list of executor env variables in code and documentation. |
Tue, 11 Oct, 18:54 |
Gastón Kleiman |
Re: Review Request 52556: Added the MESOS_RUNTIME_DIRECTORY executor env variable. |
Tue, 11 Oct, 18:59 |
Gastón Kleiman |
Re: Review Request 52556: Added the MESOS_RUNTIME_DIRECTORY executor env variable. |
Thu, 13 Oct, 11:20 |
Gastón Kleiman |
Re: Review Request 52250: Added test cases for HTTP health check. |
Thu, 13 Oct, 13:18 |
Gastón Kleiman |
Re: Review Request 52251: Added test cases for TCP health check. |
Thu, 13 Oct, 15:02 |
Gastón Kleiman |
Re: Review Request 52250: Added test cases for HTTP health check. |
Thu, 13 Oct, 15:04 |
Gastón Kleiman |
Re: Review Request 52250: Added test cases for HTTP health check. |
Thu, 13 Oct, 15:04 |
Gastón Kleiman |
Review Request 52878: Removed outdated TODO in stout::flags. |
Fri, 14 Oct, 13:35 |
Gastón Kleiman |
Review Request 52879: Updated the way in which the default and command executors load options. |
Fri, 14 Oct, 13:38 |
Gastón Kleiman |
Review Request 52880: Added "launcher_dir" to the default executor flags. |
Fri, 14 Oct, 13:39 |
Gastón Kleiman |
Re: Review Request 52556: Added the MESOS_RUNTIME_DIRECTORY executor env variable. |
Fri, 14 Oct, 13:42 |
Gastón Kleiman |
Re: Review Request 52608: Reordered the list of executor env variables in code and documentation. |
Fri, 14 Oct, 13:42 |
Gastón Kleiman |
Re: Review Request 52863: Refactored HealthCheck validation for clarity. |
Fri, 14 Oct, 13:45 |
Gastón Kleiman |
Re: Review Request 52864: Removed unnecessary sleep in HealthChecker. |
Fri, 14 Oct, 13:46 |
Gastón Kleiman |
Re: Review Request 52865: Refactored HealthChecker to never stop health checking. |
Fri, 14 Oct, 13:53 |
Gastón Kleiman |
Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument. |
Fri, 14 Oct, 13:59 |
Gastón Kleiman |
Re: Review Request 52873: Cleaned up private members in HealthChecker class. |
Fri, 14 Oct, 14:10 |
Gastón Kleiman |
Re: Review Request 52867: Used `Duration::create()` for double -> Duration conversion. |
Fri, 14 Oct, 14:18 |
Gastón Kleiman |
Re: Review Request 52868: Added pause/resume functionality to HealthChecker. |
Fri, 14 Oct, 15:28 |
Gastón Kleiman |
Re: Review Request 52869: Ensured command executor ignores health updates for terminated tasks. |
Fri, 14 Oct, 15:29 |
Gastón Kleiman |
Re: Review Request 52870: Ensured docker executor ignores health updates for terminated tasks. |
Fri, 14 Oct, 17:24 |
Gastón Kleiman |
Re: Review Request 52867: Used `Duration::create()` for double -> Duration conversion. |
Mon, 17 Oct, 11:22 |
Gastón Kleiman |
Re: Review Request 52880: Added "launcher_dir" to the default executor flags. |
Mon, 17 Oct, 12:10 |
Gastón Kleiman |
Re: Review Request 52786: Add the health check test helper. |
Mon, 17 Oct, 12:34 |
Gastón Kleiman |
Re: Review Request 52250: Added test cases for HTTP health check. |
Mon, 17 Oct, 15:19 |
Gastón Kleiman |
Re: Review Request 52251: Added test cases for TCP health check. |
Mon, 17 Oct, 16:14 |
Gastón Kleiman |
Re: Review Request 52786: Add the health check test helper. |
Fri, 21 Oct, 10:11 |
Gastón Kleiman |
Re: Review Request 52871: Ensured default executor ignores health updates for terminated tasks. |
Fri, 21 Oct, 10:27 |
Gastón Kleiman |
Re: Review Request 52878: Removed outdated TODO in stout::flags. |
Fri, 21 Oct, 11:35 |
Gastón Kleiman |
Review Request 53084: Updated the env variable used to enable SSL. |
Fri, 21 Oct, 11:36 |
Gastón Kleiman |
Re: Review Request 52879: Cleaned up the way in which the executors load configuration options. |
Fri, 21 Oct, 11:38 |
Gastón Kleiman |
Re: Review Request 52880: Added "launcher_dir" to the default executor flags. |
Fri, 21 Oct, 11:39 |
Gastón Kleiman |
Re: Review Request 52879: Cleaned up the way in which the executors load configuration options. |
Fri, 21 Oct, 11:46 |
Gastón Kleiman |
Re: Review Request 52879: Cleaned up the way in which the executors load configuration options. |
Fri, 21 Oct, 11:46 |
Gastón Kleiman |
Re: Review Request 52865: Refactored HealthChecker to never stop health checking. |
Mon, 24 Oct, 08:37 |
Gastón Kleiman |
Re: Review Request 52878: Removed outdated TODO in stout::flags. |
Mon, 24 Oct, 09:02 |
Gastón Kleiman |
Re: Review Request 53084: Updated the env variable used to enable SSL. |
Mon, 24 Oct, 09:05 |
Gastón Kleiman |
Re: Review Request 52879: Cleaned up the way in which the executors load configuration options. |
Mon, 24 Oct, 09:07 |
Gastón Kleiman |
Re: Review Request 52880: Added "launcher_dir" to the default executor flags. |
Mon, 24 Oct, 09:08 |
Gastón Kleiman |
Re: Review Request 52865: Refactored HealthChecker to never stop health checking. |
Mon, 24 Oct, 13:35 |
Gastón Kleiman |
Re: Review Request 52642: Improved the validation of RESERVE operations. |
Mon, 24 Oct, 15:25 |
Gastón Kleiman |
Re: Review Request 53121: Added a child hook for entering the target pid's namespaces. |
Tue, 25 Oct, 13:18 |
Gastón Kleiman |
Re: Review Request 53122: Used child hooks to enter namespaces in health check. |
Tue, 25 Oct, 13:20 |
Gastón Kleiman |
Re: Review Request 53147: Made health check run under the same user with tasks. |
Tue, 25 Oct, 13:28 |
Gastón Kleiman |
Re: Review Request 53146: Added a child hook for switching the user. |
Tue, 25 Oct, 13:31 |
Gastón Kleiman |
Review Request 53196: Fixed a typo in 'tests/containerizer.cpp'. |
Wed, 26 Oct, 16:56 |
Gastón Kleiman |
Review Request 53197: Added parsers for 'SlaveID', 'ExecutorID' and 'FrameworkID'. |
Wed, 26 Oct, 16:58 |
Gastón Kleiman |
Re: Review Request 52879: Cleaned up the way in which the executors load configuration options. |
Wed, 26 Oct, 17:00 |
Gastón Kleiman |
Re: Review Request 53226: Fixed HealthyTaskViaHTTPWithoutType test. |
Thu, 27 Oct, 14:20 |
Gastón Kleiman |
Re: Review Request 53084: Support `LIBPROCESS_SSL_ENABLED` in the default executor and scheduler. |
Thu, 27 Oct, 15:49 |
Gastón Kleiman |
Re: Review Request 53196: Fixed a typo in 'tests/containerizer.cpp'. |
Thu, 27 Oct, 15:50 |
Gastón Kleiman |
Re: Review Request 53197: Added parsers for 'SlaveID', 'ExecutorID' and 'FrameworkID'. |
Thu, 27 Oct, 15:51 |
Gastón Kleiman |
Review Request 53227: Added the '--launcher_dir' flag to the default executor. |
Thu, 27 Oct, 16:13 |
Gastón Kleiman |
Re: Review Request 53227: Added the '--launcher_dir' flag to the default executor. |
Thu, 27 Oct, 16:15 |
Gastón Kleiman |
Re: Review Request 53197: Added parsers for 'SlaveID', 'ExecutorID' and 'FrameworkID'. |
Thu, 27 Oct, 16:19 |
Gastón Kleiman |
Re: Review Request 53084: Support `LIBPROCESS_SSL_ENABLED` in the default executor and scheduler. |
Thu, 27 Oct, 16:20 |
Gastón Kleiman |
Re: Review Request 52878: Removed outdated TODO in stout::flags. |
Thu, 27 Oct, 16:20 |
Gastón Kleiman |
Re: Review Request 52879: Cleaned up the way in which the executors load configuration options. |
Thu, 27 Oct, 16:21 |
Gastón Kleiman |
Re: Review Request 53084: Support `LIBPROCESS_SSL_ENABLED` in the default executor and scheduler. |
Thu, 27 Oct, 17:32 |
Gastón Kleiman |
Re: Review Request 52879: Cleaned up the way in which the executors load configuration options. |
Thu, 27 Oct, 17:34 |
Gastón Kleiman |
Re: Review Request 52880: Added "launcher_dir" to the default executor flags. |
Thu, 27 Oct, 17:34 |
Gastón Kleiman |
Re: Review Request 53084: Support `LIBPROCESS_SSL_ENABLED` in the default executor and scheduler. |
Fri, 28 Oct, 11:41 |
Gastón Kleiman |
Re: Review Request 52879: Cleaned up the way in which the executors load configuration options. |
Fri, 28 Oct, 11:43 |
Gastón Kleiman |
Review Request 53266: Made DefaultExecutorTests succeed when running on hosts without Docker. |
Fri, 28 Oct, 15:28 |
Gastón Kleiman |
Re: Review Request 53266: Made DefaultExecutorTests pass when running on hosts without Docker. |
Fri, 28 Oct, 15:28 |
Gastón Kleiman |
Re: Review Request 53266: Made DefaultExecutorTests pass when running on hosts without Docker. |
Fri, 28 Oct, 18:27 |
Gastón Kleiman |
Re: Review Request 53266: Made DefaultExecutorTests pass when running on hosts without Docker. |
Fri, 28 Oct, 18:27 |
Gastón Kleiman |
Re: Review Request 53084: Support `LIBPROCESS_SSL_ENABLED` in the default executor and scheduler. |
Mon, 31 Oct, 11:44 |
Gastón Kleiman |
Re: Review Request 52879: Cleaned up the way in which the executors load configuration options. |
Mon, 31 Oct, 11:46 |
Gastón Kleiman |
Re: Review Request 52879: Cleaned up the way in which the executors load configuration options. |
Mon, 31 Oct, 11:46 |
Gastón Kleiman |
Re: Review Request 53266: Refactored `DefaultExecutorTest.ROOT_TaskRunning` [1/3]. |
Mon, 31 Oct, 16:08 |
Gastón Kleiman |
Review Request 53303: Refactored `DefaultExecutorTest.ROOT_KillTask` [2/3]. |
Mon, 31 Oct, 16:10 |
Gastón Kleiman |
Review Request 53309: Refactored `DefaultExecutorTest.ROOT_TaskUsesExecutor` [3/3]. |
Mon, 31 Oct, 16:11 |
Gastón Kleiman |
Re: Review Request 52880: Added "launcher_dir" to the default executor flags. |
Mon, 31 Oct, 17:05 |
Aaron Wood |
Review Request 52647: Fix new errors/warnings produced by hardened flags |
Fri, 07 Oct, 19:21 |
Aaron Wood |
Review Request 52645: Harden Mesos |
Fri, 07 Oct, 19:21 |
Aaron Wood |
Re: Review Request 52645: Harden Mesos |
Fri, 07 Oct, 19:22 |
Aaron Wood |
Re: Review Request 52647: Fix new errors/warnings produced by hardened flags |
Fri, 07 Oct, 19:22 |