mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 53253: Fixed the bug when search base hierarchy in `cgroups_tests.cpp`.
Date Tue, 01 Nov 2016 01:20:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53253/#review154358
-----------------------------------------------------------



We unfortunately have to copy the cleanup code from `ContainerizerTest<slave::MesosContainerizer>::SetUp()`
to here. FWIW the test fixture originally was written with co-mounted subsystems in a single
hierarchy (hence *Any*), later altered when Mesos started to use separate hierarchies for
each subsystem, but not in a clean way IMO.

The `CgroupsAnyHierarchyTest` fixture and its children AFAICT still works with one hierarchy
with multiple co-mounted subsystems. In fact Mesos does support co-mounted subsystems.

So IMO it wouldn't be a bad idea to have tests in cgroups_tests.cpp to only **create** one
hierarchy for all the specified subsystems (most tests assume one). Of course it's fine if
the subsystems are already mounted in separate hierarchies but the tests only manages (create/cleanup)
a single hierachy.

This would make fixes for related problems (e.g., MESOS-6422) cleaner as well.

Thoughts?

- Jiang Yan Xu


On Oct. 27, 2016, 10:13 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53253/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2016, 10:13 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6035
>     https://issues.apache.org/jira/browse/MESOS-6035
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed the bug when search base hierarchy in `cgroups_tests.cpp`.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_tests.cpp 0afaec6ae948cabf1472bf01103210d8f9809cb1

> 
> Diff: https://reviews.apache.org/r/53253/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message