mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 53324: Add a column for FrameworkID when displaying tasks in the WebUI
Date Tue, 01 Nov 2016 02:31:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53324/#review154362
-----------------------------------------------------------




src/webui/master/static/home.html (lines 167 - 169)
<https://reviews.apache.org/r/53324/#comment223884>

    Let's use this style to consistent with other parts.
    ```
    <a href="#/frameworks/{{task.framework_id}}/">
      {{task.framework_id}}
    </a>
    ```



src/webui/master/static/home.html (lines 220 - 222)
<https://reviews.apache.org/r/53324/#comment223882>

    Let's use `<td>{{task.framework_id}}</td>` for consistent.



src/webui/master/static/home.html (lines 271 - 273)
<https://reviews.apache.org/r/53324/#comment223883>

    Let's use `<td>{{task.framework_id}}</td>` for consistent.


- haosdent huang


On Oct. 31, 2016, 11:41 p.m., Miguel Bernadin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53324/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2016, 11:41 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-6369
>     https://issues.apache.org/jira/browse/MESOS-6369
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add a column for FrameworkID when displaying tasks in the WebUI
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/home.html 07f862f69802bef8fda2d0a94e33c3b463ddcd4c 
> 
> Diff: https://reviews.apache.org/r/53324/diff/
> 
> 
> Testing
> -------
> 
> Tested on my AWS Mesos Cluster
> 
> 
> Thanks,
> 
> Miguel Bernadin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message