mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 52587: Allow CREATE of shared volumes based on capability of framework.
Date Tue, 01 Nov 2016 07:02:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52587/#review154378
-----------------------------------------------------------


Fix it, then Ship it!





src/master/validation.hpp (line 197)
<https://reviews.apache.org/r/52587/#comment223902>

    s/shared volume is/shared volumes are/?
    
    s/FrameworkInfo/FrameworkInfo (unless the operation is requested by the operator)/



src/master/validation.cpp (line 1520)
<https://reviews.apache.org/r/52587/#comment223903>

    s/which has not opted in for SHARED_RESOURCES/with no SHARED_RESOURCES capability/ 
    
    slightly shorter and more direct about the capability?


- Jiang Yan Xu


On Oct. 6, 2016, 1:16 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52587/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2016, 1:16 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6316
>     https://issues.apache.org/jira/browse/MESOS-6316
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When a framework issues a CREATE for a shared volume, we allow that
> operation only if the framework has opted in for the capability of
> SHARED_RESOURCES. However, for HTTP operator (/create-volumes), we
> do not check as the operator API is not related to a specific
> framework.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 02a2fb29bdd8484fc90e5cb033ac29b49a141860 
>   src/master/validation.hpp 035f721c610ae566c89a1cf0e65ff0df11679f15 
>   src/master/validation.cpp e5da3c9bf0a1042b42522f1ab74ce798fbb1738d 
>   src/tests/master_validation_tests.cpp 99e350e0587e73e9ee25ef20dd369cd146bd446a 
>   src/tests/persistent_volume_tests.cpp e10a79e9662530e143ccaa2aa2506a4d25158364 
> 
> Diff: https://reviews.apache.org/r/52587/diff/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message