mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 52879: Cleaned up the way in which the executors load configuration options.
Date Tue, 01 Nov 2016 14:06:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52879/
-----------------------------------------------------------

(Updated Nov. 1, 2016, 2:06 p.m.)


Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, Jie Yu, and
Jiang Yan Xu.


Changes
-------

Rebased.


Bugs: MESOS-6494
    https://issues.apache.org/jira/browse/MESOS-6494


Repository: mesos


Description
-------

Updated the executors so that they use only `stout::flags` to load
config options.

They used to use a mix of `stout::flags` and `os::getenv`.


Diffs (updated)
-----

  src/CMakeLists.txt 639f8678ba23c4d9a2ea0bf84fbc3d6fc9286ef3 
  src/Makefile.am c2f9e442182110d0b450d4824600a4a791f8cf27 
  src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6 
  src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 
  src/exec/exec.cpp 1dc20390907253a466b7272b7f8b33ea14afb236 
  src/exec/flags.hpp PRE-CREATION 
  src/exec/flags.cpp PRE-CREATION 
  src/executor/executor.cpp 1d47b52d89eedee59d160badd6313d34e3bdb6d2 
  src/executor/flags.hpp PRE-CREATION 
  src/executor/flags.cpp PRE-CREATION 
  src/launcher/default_executor.cpp 10ca94ca3e584431d0dd7bf3b8bae98caca7eba9 
  src/launcher/executor.hpp 217680d99d6e8c31130d7dc714f8cd730f360852 
  src/launcher/executor.cpp 0544121e679db503fe4eaf23a24e315eb188a520 
  src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 
  src/tests/containerizer.cpp c2208660352e5cf62cec5c7b92ec67fea62aea49 

Diff: https://reviews.apache.org/r/52879/diff/


Testing
-------

`make check`


Thanks,

Gastón Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message