mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.
Date Tue, 01 Nov 2016 15:04:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50599/#review154407
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


src/slave/containerizer/docker.hpp (line 509)
<https://reviews.apache.org/r/50599/#comment223933>

    You also need to `include <vector>` at the beginning of this file.



src/slave/containerizer/docker.cpp (line 701)
<https://reviews.apache.org/r/50599/#comment223935>

    You need to keep the comments from Kevin as open here https://reviews.apache.org/r/50599/#comment223322



src/slave/containerizer/docker.cpp (lines 705 - 710)
<https://reviews.apache.org/r/50599/#comment223934>

    What about update this a bit to make it less jagged?
    
    ```
      // NOTE: GPU devices permissions are required to be `rmw` by default,
      // that is because GPU tasks launched in the container may need to
      // read/write/mknod to GPU devices in their lifecycle.
      //
      // `container->devices` records Nvidia GPU devices to be attached to
      // the docker container.
    ```


- Guangya Liu


On 十一月 1, 2016, 9:11 a.m., Yubo Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50599/
> -----------------------------------------------------------
> 
> (Updated 十一月 1, 2016, 9:11 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
>     https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Assigned Nvidia GPU devices to docker container based on
> GPUs allocated by Nvidia GPU allocator.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 
>   src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d 
>   src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 
> 
> Diff: https://reviews.apache.org/r/50599/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message