mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.
Date Tue, 01 Nov 2016 15:31:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50127/#review154410
-----------------------------------------------------------




src/tests/containerizer/docker_containerizer_tests.cpp (line 4093)
<https://reviews.apache.org/r/50127/#comment223939>

    ```
    foreach(const Docker::Device& device, inspect->devices) {
    ```



src/tests/containerizer/docker_containerizer_tests.cpp (lines 4094 - 4095)
<https://reviews.apache.org/r/50127/#comment223940>

    It is not good to use `count()` as a boolean value, what about following?
    
    ```
    EXPECT_EQ(1u, devicePaths.count(device.hostPath));
    EXPECT_EQ(1u, devicePaths.count(device.containerPath));
    ```


- Guangya Liu


On 十一月 1, 2016, 9:12 a.m., Yubo Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50127/
> -----------------------------------------------------------
> 
> (Updated 十一月 1, 2016, 9:12 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
>     https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This added a testing case for end-to-end GPU support for docker
> containerizer.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 810488d1476cadbbd5a4a7dcecaeec55739ab71f

> 
> Diff: https://reviews.apache.org/r/50127/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message