mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 52587: Allow CREATE of shared volumes based on capability of framework.
Date Tue, 01 Nov 2016 16:54:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52587/
-----------------------------------------------------------

(Updated Nov. 1, 2016, 4:54 p.m.)


Review request for mesos and Jiang Yan Xu.


Changes
-------

Addressed review comments.


Bugs: MESOS-6316
    https://issues.apache.org/jira/browse/MESOS-6316


Repository: mesos


Description
-------

When a framework issues a CREATE for a shared volume, we allow that
operation only if the framework has opted in for the capability of
SHARED_RESOURCES. However, for HTTP operator (/create-volumes), we
do not check as the operator API is not related to a specific
framework.


Diffs (updated)
-----

  src/master/master.cpp 013bb592ba47b785c552e199633e4784e8aa71b1 
  src/master/validation.hpp 035f721c610ae566c89a1cf0e65ff0df11679f15 
  src/master/validation.cpp f690a9eacd278b51a52f5588dbeea377df074435 
  src/tests/master_validation_tests.cpp a5d8610bd61822cdf55cbc8d7056e5cf8fecfa54 
  src/tests/persistent_volume_tests.cpp 6289009fe9ed0a57ba5eff46dbbe0633a75d2616 

Diff: https://reviews.apache.org/r/52587/diff/


Testing
-------

All tests passed.


Thanks,

Anindya Sinha


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message