mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 52886: Fix new sign comparison errors in stout produced by hardened flags
Date Wed, 02 Nov 2016 09:54:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52886/#review154529
-----------------------------------------------------------


Fix it, then Ship it!




Looks great, thanks a lot for cleaning these up.


3rdparty/stout/tests/ip_tests.cpp (line 50)
<https://reviews.apache.org/r/52886/#comment224127>

    `ASSERT_SOME(numify<int>(prefix))`.



3rdparty/stout/tests/ip_tests.cpp (line 51)
<https://reviews.apache.org/r/52886/#comment224126>

    Fits on a single line.



3rdparty/stout/tests/json_tests.cpp (line 175)
<https://reviews.apache.org/r/52886/#comment224129>

    Not yours, but the ordering of parameters (should be `expected, actual`) is wrong here
and in many other places in this file.
    
    It would be great if you could submit a separate cleanup patch for that.



3rdparty/stout/tests/os_tests.cpp (line 711)
<https://reviews.apache.org/r/52886/#comment224128>

    While this is the ultimately correct way, we tend to just use `size_t` for `vector<gid_t>::size_type`.
    
    Alternatively we could just replace this loop with
    
       foreach (gid_t gid, gids.get()) {
         expected_gids.push_back(stringify(gid));
       }


- Benjamin Bannier


On Oct. 27, 2016, 9:32 p.m., Aaron Wood wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52886/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2016, 9:32 p.m.)
> 
> 
> Review request for mesos, James Peach, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-6239
>     https://issues.apache.org/jira/browse/MESOS-6239
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The hardening flags produced many new sign comparison errors in stout that need to be
fixed for Mesos to compile/run.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/tests/cache_tests.cpp 0950c85 
>   3rdparty/stout/tests/flags_tests.cpp da4deb9 
>   3rdparty/stout/tests/hashmap_tests.cpp 2626d67 
>   3rdparty/stout/tests/hashset_tests.cpp 66e59db 
>   3rdparty/stout/tests/ip_tests.cpp b5a206f 
>   3rdparty/stout/tests/json_tests.cpp 2bc4c88 
>   3rdparty/stout/tests/linkedhashmap_tests.cpp 7a80769 
>   3rdparty/stout/tests/multimap_tests.cpp 488991b 
>   3rdparty/stout/tests/os/process_tests.cpp 4cb3b5f 
>   3rdparty/stout/tests/os/sendfile_tests.cpp e221689 
>   3rdparty/stout/tests/os/systems_tests.cpp 110ba5b 
>   3rdparty/stout/tests/os_tests.cpp 0b7ee07 
>   3rdparty/stout/tests/strings_tests.cpp 7dd3301 
> 
> Diff: https://reviews.apache.org/r/52886/diff/
> 
> 
> Testing
> -------
> 
> Made sure compilation, tests, and benchmarks worked with both gcc and clang. Ran make
&& make check && make bench.
> 
> 
> Thanks,
> 
> Aaron Wood
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message