mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 52754: Remove unused code which now throws errors with the new hardening flags
Date Wed, 02 Nov 2016 11:02:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52754/#review154535
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/src/profiler.cpp (line 35)
<https://reviews.apache.org/r/52754/#comment224146>

    Not yours, but could you please `const` with `constexpr` here?



3rdparty/libprocess/src/profiler.cpp (line 36)
<https://reviews.apache.org/r/52754/#comment224145>

    Not yours, but could you remove the extra space after the closing paren,
    
        } // namespace {


- Benjamin Bannier


On Oct. 25, 2016, 10:32 p.m., Aaron Wood wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52754/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2016, 10:32 p.m.)
> 
> 
> Review request for mesos, James Peach, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-6239
>     https://issues.apache.org/jira/browse/MESOS-6239
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The hardening flags produced many new errors about unused functions, variables, etc.
that need to be fixed for Mesos to compile/run.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/profiler.hpp f6fccfb 
>   3rdparty/libprocess/src/profiler.cpp 0c4949e 
>   3rdparty/libprocess/src/tests/benchmarks.cpp 945007c 
>   3rdparty/libprocess/src/tests/process_tests.cpp 3936f47 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp c8350cf 
> 
> Diff: https://reviews.apache.org/r/52754/diff/
> 
> 
> Testing
> -------
> 
> Made sure compilation, tests, and benchmarks worked with both gcc and clang. Ran make
&& make check && make bench.
> 
> 
> Thanks,
> 
> Aaron Wood
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message