mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Review Request 53378: Made the executors skip health updates after killing a task.
Date Wed, 02 Nov 2016 15:36:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53378/
-----------------------------------------------------------

Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-6457
    https://issues.apache.org/jira/browse/MESOS-6457


Repository: mesos


Description
-------

The command and Docker executors would send health updates even after
having transitioned a task to `TASK_KILLING`, leading to `TASK_KILLING
-> TASK_RUNNING` transitions.

This patch makes those executors skip health updates after starting to
kill a task.


Diffs
-----

  src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 
  src/launcher/executor.cpp 0544121e679db503fe4eaf23a24e315eb188a520 
  src/tests/command_executor_tests.cpp 6e47243941626bb5b6224430f9a12ced8a3f5062 
  src/tests/containerizer/docker_containerizer_tests.cpp 810488d1476cadbbd5a4a7dcecaeec55739ab71f


Diff: https://reviews.apache.org/r/53378/diff/


Testing
-------

Added new tests and made sure that they fail on both OS X and Linux without the executor changes.

They pass with the executor changes.


Thanks,

Gastón Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message