mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 53386: Fixed memory leak in JVM code.
Date Wed, 02 Nov 2016 16:39:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53386/#review154578
-----------------------------------------------------------




src/jvm/jvm.cpp (lines 90 - 95)
<https://reviews.apache.org/r/53386/#comment224200>

    This will work as long nobody adds new `return` statements before the corresponding `delete`.
    
    Could we use a `std::vector<JavaVMOption>` here for easier maintenance? Note that
you can access the raw memory block of the entries like
    
        // conditional on `options.size() != 0`
        vmArgs.options = &opts[0];


- Benjamin Bannier


On Nov. 2, 2016, 5:23 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53386/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2016, 5:23 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed memory leak in JVM code.
> 
> 
> Diffs
> -----
> 
>   src/jvm/jvm.cpp 62f7857180162c510269b5d10f5add94ab354fa2 
> 
> Diff: https://reviews.apache.org/r/53386/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Verified that observed `clang-tidy` leak warning goes away with this change.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message