mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 53378: Made the executors skip health updates after killing a task.
Date Wed, 02 Nov 2016 19:27:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53378/#review154617
-----------------------------------------------------------



Hm.. the breakdown between (1) https://reviews.apache.org/r/53378/ and (2) https://reviews.apache.org/r/53385/
seems a bit odd to me:

(1) Fixes both command and docker executors, but adds a test for command executor.
(2) Adds a test for docker executor, but the commit summary makes it sound like the fix itself.

How about structuring this as follows:

(1) Fix the command executor case.
(2) Add a test for the command executor case.
(3) Fix the docker executor case.
(4) Add a test for the docker executor case.

Feel free to bundle (1) + (2) or (3) + (4) into a single patch if you want to combine the
fix with the tests, but in general smaller reviews are nicer.

Some suggestions for commit summaries:

(1) Fixed the command executor to not generate RUNNING after KILLING.
(2) Add a test to ensure MESOS-6457 is fixed for the command executor.
(3) Fixed the docker executor to not generate RUNNING after KILLING.
(4) Add a test to ensure MESOS-6457 is fixed for the docker executor.

- Benjamin Mahler


On Nov. 2, 2016, 3:52 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53378/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2016, 3:52 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6457
>     https://issues.apache.org/jira/browse/MESOS-6457
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The command and Docker executors would send health updates even after
> having transitioned a task to `TASK_KILLING`, leading to `TASK_KILLING
> -> TASK_RUNNING` transitions.
> 
> This patch makes those executors skip health updates after starting to
> kill a task.
> 
> The test for the Docker executor goes in a separate patch, because it
> uses a TCP health check that aren't available in Mesos 0.28.x.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG ed78657492eb3a708cdeaf9cf40d0a70270a5699 
>   src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 
>   src/launcher/executor.cpp 0544121e679db503fe4eaf23a24e315eb188a520 
>   src/tests/command_executor_tests.cpp 6e47243941626bb5b6224430f9a12ced8a3f5062 
> 
> Diff: https://reviews.apache.org/r/53378/diff/
> 
> 
> Testing
> -------
> 
> Added a test ensuring that the command executor doesn't transition tasks from `TASK_KILLING`
to `TASK_RUNNING`. It fails on both OS X and Linux without the executor changes.
> 
> It passes with the executor changes.
> 
> The next patch in the chain adds a test for the Docker executor.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message