mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 53466: Added test to verify container status for nested containers.
Date Fri, 04 Nov 2016 17:53:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53466/#review154946
-----------------------------------------------------------




src/tests/mesos.hpp (line 365)
<https://reviews.apache.org/r/53466/#comment224738>

    Why is this pulled in if it's now used anywhere? Does some of the macro magic below actually
reference this type?



src/tests/mesos.hpp (lines 1867 - 1875)
<https://reviews.apache.org/r/53466/#comment224737>

    This seems like a logically different change that should have its own commit message explaining
why this is changed this way.


- Kevin Klues


On Nov. 4, 2016, 7:08 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53466/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2016, 7:08 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: MESOS-6465 and MESOS-6528
>     https://issues.apache.org/jira/browse/MESOS-6465
>     https://issues.apache.org/jira/browse/MESOS-6528
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch is used to verify that container status is properly set in
> task status update for nested containers.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp db953d39a95e7e95871054114a0a9bbeded46224 
>   src/tests/mesos.hpp f521d22eeafd1901d1acf42c168824b922b68743 
> 
> Diff: https://reviews.apache.org/r/53466/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message