mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 50974: Documented all the API calls for Operator HTTP API.
Date Fri, 04 Nov 2016 18:30:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50974/#review154956
-----------------------------------------------------------



Thanks for doing this. Awesome! Some minor suggestions before we can commit this.


docs/operator-http-api.md 
<https://reviews.apache.org/r/50974/#comment224747>

    Instead of just the JSON, we need to add some text on what these calls will do. Look at
scheduler and executor docs.



docs/operator-http-api.md (line 32)
<https://reviews.apache.org/r/50974/#comment224743>

    Can follow the same order as the enums in call? The first one should be GET_HEALTH



docs/operator-http-api.md (line 66)
<https://reviews.apache.org/r/50974/#comment224746>

    I would pull to the `type` to the top of the JSON like we did the scheduler and executor
api docs.



docs/operator-http-api.md (line 72)
<https://reviews.apache.org/r/50974/#comment224748>

    202 Accepted? here and everywhere else.


- Vinod Kone


On Aug. 11, 2016, 8:33 a.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50974/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2016, 8:33 a.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Bugs: MESOS-5992
>     https://issues.apache.org/jira/browse/MESOS-5992
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Documented all the API calls for Operator HTTP API.
> 
> 
> Diffs
> -----
> 
>   docs/operator-http-api.md 4f4c39e7b4b6de32af1933c34eba21f126fae8ac 
> 
> Diff: https://reviews.apache.org/r/50974/diff/
> 
> 
> Testing
> -------
> 
> Checked the generated page through "rake dev".
> Validated and formatted all the JSON snippets with:
> http://jsonlint.com/
> http://jsonviewer.stack.hu/
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message