mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 53451: Added agent API protos for executing and attaching nested containers.
Date Fri, 04 Nov 2016 20:23:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53451/#review154982
-----------------------------------------------------------




include/mesos/agent/agent.proto (line 159)
<https://reviews.apache.org/r/53451/#comment224798>

    s/in streaming response/in a streaming response/



include/mesos/agent/agent.proto (line 338)
<https://reviews.apache.org/r/53451/#comment224799>

    It is also the streaming response to `Call::ATTACH_CONTAINER_OUTPUT`



include/mesos/v1/agent/agent.proto (line 35)
<https://reviews.apache.org/r/53451/#comment224800>

    s/Call::NestedContainerSession/Call::LaunchNestedContainerSession
    
    Also, we should add a similar comment in the *non-v1* agent.proto file.



include/mesos/v1/agent/agent.proto (line 159)
<https://reviews.apache.org/r/53451/#comment224801>

    s/in streaming response/in a streaming response/



include/mesos/v1/agent/agent.proto (line 338)
<https://reviews.apache.org/r/53451/#comment224802>

    Also true for `Call::ATTACH_CONTAINER_OUTPUT`


- Kevin Klues


On Nov. 4, 2016, 12:36 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53451/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2016, 12:36 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, Jie Yu, and Kevin Klues.
> 
> 
> Bugs: MESOS-6525
>     https://issues.apache.org/jira/browse/MESOS-6525
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch only contains the proto definitions. The implementation is
> not yet present.
> 
> 
> Diffs
> -----
> 
>   include/mesos/agent/agent.proto 0e9e071d1b97ba41c1636e41f242d564998e8f0b 
>   include/mesos/v1/agent/agent.proto c2f282c05d15ae1fa099cd26ceb66d41e52b1d95 
>   src/slave/http.cpp a32aca437cffd52bc2bcde859eedddca2038e3f1 
>   src/slave/validation.cpp 974bf24f1e139e409cc4b6363b646ff50d57df1e 
> 
> Diff: https://reviews.apache.org/r/53451/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message