mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Review Request 53500: Used an environment variable to pass command environment.
Date Fri, 04 Nov 2016 21:29:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53500/
-----------------------------------------------------------

Review request for mesos, Anindya Sinha, Gilbert Song, and Jie Yu.


Bugs: MESOS-6526
    https://issues.apache.org/jira/browse/MESOS-6526


Repository: mesos


Description
-------

Used an environment variable to pass command environment.


Diffs
-----

  src/slave/containerizer/mesos/containerizer.cpp 67cc595278f124cdf518d2f4fcfb257439f067e2

  src/slave/containerizer/mesos/launch.hpp 8b23c1b6df6bc1fdd987af5a4469664356e7f27a 
  src/slave/containerizer/mesos/launch.cpp 377a9d94aa780ab598b1c2034c10ce25a4e02cbe 
  src/slave/containerizer/mesos/main.cpp 1a0e765ddb6d8519426b8d47067efdfa3432e07a 

Diff: https://reviews.apache.org/r/53500/diff/


Testing
-------

make check.

No new tests are written but the fact the existing tests that run exectuors depends on this
to work correctly is a proof.


Thanks,

Jiang Yan Xu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message