mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 53466: Added test to verify container status for nested containers.
Date Fri, 04 Nov 2016 23:28:29 GMT


> On Nov. 4, 2016, 5:53 p.m., Kevin Klues wrote:
> > src/tests/mesos.hpp, line 365
> > <https://reviews.apache.org/r/53466/diff/1/?file=1554140#file1554140line365>
> >
> >     Why is this pulled in if it's now used anywhere? Does some of the macro magic
below actually reference this type?

It's used in the test because we want to do v1::ContainerStatus in the test and this is necessary
to disambguate with internal::tests::v1 namespace.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53466/#review154946
-----------------------------------------------------------


On Nov. 4, 2016, 7:08 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53466/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2016, 7:08 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: MESOS-6465 and MESOS-6528
>     https://issues.apache.org/jira/browse/MESOS-6465
>     https://issues.apache.org/jira/browse/MESOS-6528
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch is used to verify that container status is properly set in
> task status update for nested containers.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp db953d39a95e7e95871054114a0a9bbeded46224 
>   src/tests/mesos.hpp f521d22eeafd1901d1acf42c168824b922b68743 
> 
> Diff: https://reviews.apache.org/r/53466/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message