mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 52865: Refactored HealthChecker to never stop health checking.
Date Wed, 23 Nov 2016 00:28:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52865/
-----------------------------------------------------------

(Updated Nov. 23, 2016, 12:28 a.m.)


Review request for mesos, Anand Mazumdar, Benjamin Mahler, Gastón Kleiman, and haosdent huang.


Bugs: MESOS-5963
    https://issues.apache.org/jira/browse/MESOS-5963


Repository: mesos


Description
-------

Prior to this patch, HealthChecker would stop performing health
checks after it marks the task for kill. Since tasks' lifecycle
is managed by scheduler-executor, HealthChecker should never stop
health checking on its own.


Diffs (updated)
-----

  src/docker/executor.cpp eefbc0c2936eb93044c2d8a1b50155171f398562 
  src/health-check/health_checker.hpp 837d1358e418d21536da488e4a23cbfa41db6060 
  src/health-check/health_checker.cpp af5500be249c74a4a5e64bf38dea607173e2f998 
  src/launcher/default_executor.cpp f4e1ea4816fee9a2f6d59bb534933b66013f11cf 
  src/launcher/executor.cpp ce0b199551447504bb95743df4ce9ec4a0443cd4 

Diff: https://reviews.apache.org/r/52865/diff/


Testing
-------

See https://reviews.apache.org/r/52873/.


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message