mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 52871: Ensured default executor ignores health updates for terminated tasks.
Date Wed, 23 Nov 2016 00:50:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52871/
-----------------------------------------------------------

(Updated Nov. 23, 2016, 12:50 a.m.)


Review request for mesos, Anand Mazumdar, Benjamin Mahler, Gastón Kleiman, and haosdent huang.


Bugs: MESOS-5963
    https://issues.apache.org/jira/browse/MESOS-5963


Repository: mesos


Description (updated)
-------

After the task has been terminated, its health updates become
irrelevant and should be ignored. Also if the default executor
shuts down, we can safely stop all health checkers.

Technically health checking should be stopped right before
TASK_KILLING update is sent to avoid subsequent TASK_RUNNING
updates, but the default executor currently does not support
TASK_KILLING.


Diffs (updated)
-----

  src/launcher/default_executor.cpp f4e1ea4816fee9a2f6d59bb534933b66013f11cf 

Diff: https://reviews.apache.org/r/52871/diff/


Testing
-------

See https://reviews.apache.org/r/52873/.


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message