mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Lai <ja...@jasonlai.net>
Subject Re: Review Request 53546: Added stub classes for rest cgroups subsystems.
Date Wed, 23 Nov 2016 01:20:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53546/#review156678
-----------------------------------------------------------




src/CMakeLists.txt (line 173)
<https://reviews.apache.org/r/53546/#comment226879>

    Should be `pids.cpp` instead of `pid.cpp`?



src/Makefile.am (line 1058)
<https://reviews.apache.org/r/53546/#comment226880>

    `pids.cpp`?



src/Makefile.am (line 1100)
<https://reviews.apache.org/r/53546/#comment226881>

    `pids.hpp`?



src/slave/containerizer/mesos/containerizer.cpp (line 309)
<https://reviews.apache.org/r/53546/#comment226883>

    `{"cgroups/pids", &CgroupsIsolatorProcess::create}`,?



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 90)
<https://reviews.apache.org/r/53546/#comment226884>

    `pids` instead of `pid`?



src/slave/containerizer/mesos/isolators/cgroups/constants.hpp (line 52)
<https://reviews.apache.org/r/53546/#comment226885>

    `const std::string CGROUP_SUBSYSTEM_PIDS_NAME = "pids";`



src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp (line 33)
<https://reviews.apache.org/r/53546/#comment226887>

    See above



src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp (line 63)
<https://reviews.apache.org/r/53546/#comment226888>

    `{CGROUP_SUBSYSTEM_PIDS_NAME, &PidsSubsystem::create},`



src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpuset.hpp (line 38)
<https://reviews.apache.org/r/53546/#comment226890>

    `CpuSetSubsystem`?



src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpuset.cpp (line 37)
<https://reviews.apache.org/r/53546/#comment226891>

    `CpuSetSubsystem`?



src/slave/containerizer/mesos/isolators/cgroups/subsystems/pid.hpp (lines 38 - 54)
<https://reviews.apache.org/r/53546/#comment226893>

    `PidsSubsystem`?



src/slave/containerizer/mesos/isolators/cgroups/subsystems/pid.cpp (line 19)
<https://reviews.apache.org/r/53546/#comment226894>

    `pids.hpp`?



src/slave/containerizer/mesos/isolators/cgroups/subsystems/pid.cpp (lines 29 - 41)
<https://reviews.apache.org/r/53546/#comment226895>

    `PidsSubsystem` and `"cgroups-pids-subsystem"`?


- Jason Lai


On Nov. 15, 2016, 5:18 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53546/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2016, 5:18 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, Qian Zhang, and Jiang Yan
Xu.
> 
> 
> Bugs: MESOS-6558
>     https://issues.apache.org/jira/browse/MESOS-6558
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added stub classes for rest cgroups subsystems.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f 
>   src/Makefile.am 5a47c93388234a68c3c486a021ccdbe3213c5bac 
>   src/slave/containerizer/mesos/containerizer.cpp 67cc595278f124cdf518d2f4fcfb257439f067e2

>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 2f6723c64261fb3295626d6479fe844fb23b0650

>   src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 8c73efdfcfd3cf48a12cf81fcd075166dc51d7e3

>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp bf7dc9e7efb183879bfb525cc7ecfac4cc53dbef

>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/blkio.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/blkio.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpuset.hpp PRE-CREATION

>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpuset.cpp PRE-CREATION

>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/hugetlb.hpp PRE-CREATION

>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/hugetlb.cpp PRE-CREATION

>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/net_prio.hpp PRE-CREATION

>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/net_prio.cpp PRE-CREATION

>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/pid.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/pid.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53546/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message