mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 53610: Added health checks documentation.
Date Wed, 23 Nov 2016 04:33:55 GMT


> On Nov. 9, 2016, 5:32 p.m., haosdent huang wrote:
> > docs/health-checks.md, line 29
> > <https://reviews.apache.org/r/53610/diff/1/?file=1559478#file1559478line29>
> >
> >     s/functionality/functionalities/g
> 
> Alexander Rukletsov wrote:
>     I believe it is fine to use singular here. That's what my dictionary says:
>     "the range of operations that can be run on a computer or other electronic system:
new software with additional functionality."

Got it! Thanks you :)


> On Nov. 9, 2016, 5:32 p.m., haosdent huang wrote:
> > docs/health-checks.md, line 53
> > <https://reviews.apache.org/r/53610/diff/1/?file=1559478#file1559478line53>
> >
> >     Should remove `---` in this line?
> 
> Alexander Rukletsov wrote:
>     It is supposed to be rendered as em dash, for example, look at failover section in
Quota doc: https://mesos.apache.org/documentation/latest/quota/

Cool


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53610/#review155454
-----------------------------------------------------------


On Nov. 20, 2016, 6:52 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53610/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2016, 6:52 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, haosdent huang, Neil Conway, and Till Toenshoff.
> 
> 
> Bugs: MESOS-5597
>     https://issues.apache.org/jira/browse/MESOS-5597
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/health-checks.md PRE-CREATION 
>   docs/home.md a5811480de050352dca6c0f7e4e64d3d2351c2d5 
> 
> Diff: https://reviews.apache.org/r/53610/diff/
> 
> 
> Testing
> -------
> 
> https://gist.github.com/rukletsov/7200c36b2fd1e81f78f2583e68b31fd1
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message