mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 53954: Made Zk error message more accurate.
Date Wed, 23 Nov 2016 16:11:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53954/#review156748
-----------------------------------------------------------


Ship it!





src/zookeeper/group.cpp (line 604)
<https://reviews.apache.org/r/53954/#comment227022>

    I would prepend that with `const`. On the other side, there are more local variables in
this scope that are `const` in nature but are not marked so.
    
    Please feel free to `const`-annotate all vars in this scope to stay locally consistent.


- Alexander Rukletsov


On Nov. 23, 2016, 4:03 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53954/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2016, 4:03 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If Zk node creation fails, we should report the full Zk path that we
> tried to create.
> 
> 
> Diffs
> -----
> 
>   src/zookeeper/group.cpp 1df4b54883d451fe36f132af45f2f7c77f3f221b 
> 
> Diff: https://reviews.apache.org/r/53954/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message