mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 53610: Added health checks documentation.
Date Wed, 23 Nov 2016 16:39:57 GMT


> On Nov. 22, 2016, 8:34 p.m., Neil Conway wrote:
> > docs/health-checks.md, line 19
> > <https://reviews.apache.org/r/53610/diff/2/?file=1567486#file1567486line19>
> >
> >     The phrase "incorporating network failures in health check information is not
always desirable" is vague. What is the specific concern here?

The concern is that the task may be perfectly fine, but the network connection between the
scheduler and the task is currently flaky, resulting in health check failures.

How about this: "moreover, network failures between the task and the scheduler may make the
latter think that the former is unhealthy, which might not be the case."


> On Nov. 22, 2016, 8:34 p.m., Neil Conway wrote:
> > docs/health-checks.md, line 21
> > <https://reviews.apache.org/r/53610/diff/2/?file=1567486#file1567486line21>
> >
> >     Isn't a major advantage of Mesos-native health checks is that you avoid the
scalability problems of having a single scheduler handle the health checks for a potentially
large number of tasks?

I though that's exactly what this sentence says : )


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53610/#review156617
-----------------------------------------------------------


On Nov. 20, 2016, 6:52 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53610/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2016, 6:52 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, haosdent huang, Neil Conway, and Till Toenshoff.
> 
> 
> Bugs: MESOS-5597
>     https://issues.apache.org/jira/browse/MESOS-5597
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/health-checks.md PRE-CREATION 
>   docs/home.md a5811480de050352dca6c0f7e4e64d3d2351c2d5 
> 
> Diff: https://reviews.apache.org/r/53610/diff/
> 
> 
> Testing
> -------
> 
> https://gist.github.com/rukletsov/7200c36b2fd1e81f78f2583e68b31fd1
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message