mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.
Date Sun, 27 Nov 2016 00:48:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53699/#review156958
-----------------------------------------------------------



Bad patch!

Reviews applied: [53699, 53473, 52310, 52308]

Failed command: ./support/apply-review.sh -n -r 53699

Error:
2016-11-27 00:47:53 URL:https://reviews.apache.org/r/53699/diff/raw/ [8519/8519] -> "53699.patch"
[1]
error: patch failed: src/tests/container_logger_tests.cpp:40
error: src/tests/container_logger_tests.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/16224/console

- Mesos ReviewBot


On Nov. 26, 2016, 11:50 p.m., Sivaram Kannan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53699/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2016, 11:50 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5856
>     https://issues.apache.org/jira/browse/MESOS-5856
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add test cases to test logrotate with switch_user set to true and false.
> 
> 
> Diffs
> -----
> 
>   src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f 
> 
> Diff: https://reviews.apache.org/r/53699/diff/
> 
> 
> Testing
> -------
> 
> Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are
getting rotated.
> Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated.
> 
> 
> Thanks,
> 
> Sivaram Kannan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message