mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 50523: Updated docker recovery to account for GPU resources.
Date Sun, 27 Nov 2016 04:46:23 GMT


> On 十一月 5, 2016, 12:56 p.m., Guangya Liu wrote:
> > src/slave/containerizer/docker.cpp, lines 1054-1060
> > <https://reviews.apache.org/r/50523/diff/4/?file=1554223#file1554223line1054>
> >
> >     The `recoverDevices` will block here, what about using continuation as https://github.com/apache/mesos/blob/master/src/slave/containerizer/docker.cpp#L1373-L1390
?

You may also want to use a future list to handle the loop here, there is a reference here
https://github.com/apache/mesos/blob/1.1.x/src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp#L443-L461


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50523/#review155041
-----------------------------------------------------------


On 十一月 4, 2016, 9:22 a.m., Rajat Phull wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50523/
> -----------------------------------------------------------
> 
> (Updated 十一月 4, 2016, 9:22 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, Yubo Li, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-5795
>     https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated docker recovery to account for GPU resources.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.hpp 006f929eca0e0a6b1de941821ac72869ba393d2d 
>   src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c 
>   src/tests/containerizer/docker_containerizer_tests.cpp c478d56ffd734b26fd2dbd7bb1ca02ce929f3f16

> 
> Diff: https://reviews.apache.org/r/50523/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_LaunchWithGpuRecovery" make
-j check
> 
> 
> Thanks,
> 
> Rajat Phull
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message