mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Review Request 54102: Moved the default PATH setting to containerizer.
Date Sun, 27 Nov 2016 07:48:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54102/
-----------------------------------------------------------

Review request for mesos, Gilbert Song and Kevin Klues.


Bugs: MESOS-6648
    https://issues.apache.org/jira/browse/MESOS-6648


Repository: mesos


Description
-------

Currently, it is set as part of the executor environment. This is not
ideal because isolators might choose to set environment variables for
the contianer. We should set the default PATH in the last step (right
before launch) if it does not exist.

Mesos containerizer launch helper already does default PATH setting
right before launching the container. This patch did the same in
Docker containerizer, and remove the default PATH setting when
generating the executor environment.


Diffs
-----

  src/slave/containerizer/docker.cpp a8e522fc058f50560e8ec162c31be079e620bf9d 
  src/slave/slave.cpp 521f08d59cd78f9089d58cd3294f0ee4a099cd7f 

Diff: https://reviews.apache.org/r/54102/diff/


Testing
-------

sudo make check


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message