mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Review Request 54103: Made MesosContainerizer launch helper to take ContainerLaunchInfo.
Date Sun, 27 Nov 2016 07:49:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54103/
-----------------------------------------------------------

Review request for mesos, Gilbert Song and Kevin Klues.


Bugs: MESOS-6648
    https://issues.apache.org/jira/browse/MESOS-6648


Repository: mesos


Description
-------

Prior to this patch, the launch helper takes various flags from
MesosContainerizer to launch the container. This makes it very hard to
add more parameters to the launch helper. This patch simplifies this
by passing 'ContainerLaunchInfo' instead. 'ContainerLaunchInfo' is
also the protobuf message returned by isolators during 'prepare()'.
This makes it very easy to merge them and send it to the launch
helper. More importantly, this makes it very easy to add more
parameters to the launch helper in the future.


Diffs
-----

  include/mesos/slave/containerizer.proto 2621522ae59cf9275f607679b4678ac54508993d 
  src/launcher/posix/executor.cpp da0081c0e470aebb16d2e78031d276f5d7d2c726 
  src/slave/containerizer/mesos/containerizer.cpp 9b33495d9babc3ee489a8712fe1977746c41043f

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 6f0d6b0c9c1d78e5fecbbef4c6ff03825356799d

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 8f024d084189b59bb229c63d20108e7bfe42065f

  src/slave/containerizer/mesos/isolators/filesystem/shared.cpp d16b42f2231ba2e7779e798efe05e2bbd20dfac9

  src/slave/containerizer/mesos/isolators/namespaces/pid.cpp 5bf5ffbceed1229fad35ca94f42b93c097152fe5

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 3b2d4db325b23a13fa0c1a4035f309816de181fd

  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp a994adf78898b0e55ced8a2214287a97edc16d38

  src/slave/containerizer/mesos/launch.hpp 155e3c5a27b8c710971ee4b508600d3b5589a2e0 
  src/slave/containerizer/mesos/launch.cpp 320e42748adbabf09f77cb4f5951e2a7ea58fe64 
  src/tests/containerizer/port_mapping_tests.cpp 79b0a60c48a81c2f868d361ca07373bf3c2a8477


Diff: https://reviews.apache.org/r/54103/diff/


Testing
-------

sudo make check


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message