mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojian...@cn.ibm.com>
Subject Re: Review Request 54062: Added logic to validate FrameworkInfo roles.
Date Sun, 27 Nov 2016 16:12:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54062/
-----------------------------------------------------------

(Updated Nov. 27, 2016, 4:12 p.m.)


Review request for mesos, Benjamin Mahler, Guangya Liu, and Qiang Zhang.


Changes
-------

addressed guangya's comments


Bugs: MESOS-6629
    https://issues.apache.org/jira/browse/MESOS-6629


Repository: mesos


Description
-------

We need to do necessary validation for the conflicts of role, roles
and MULTI_ROLE capability. It complies with following matrix:

-- MULTI_ROLE is NOT set -
        |-------|---------|
        |Roles  |No Roles |
|-------|-------|---------|
|Role   | Error |  None   |
|-------|-------|---------|
|No Role| Error |  None   |
|-------|-------|---------|

--- MULTI_ROLE is set ----
        |-------|---------|
        |Roles  |No Roles |
|-------|-------|---------|
|Role   | Error |  Error  |
|-------|-------|---------|
|No Role| None  |  None   |
|-------|-------|---------|

One test case is added to ensure validateRoles() catches invalid
combination of these attributes. Another three test cases are added
to ensure the master accepts/rejects subscription given valid/invalid
multiple roles.


Diffs (updated)
-----

  src/master/master.cpp e03a2e8025943825a2902102c43dc0eb66bacb6a 
  src/master/validation.hpp b8389460f34b3531f2b6ff93f18f496c01e1a079 
  src/master/validation.cpp 42d9b4a8784c2a161b74d7b46619cc22272e14e3 
  src/tests/master_validation_tests.cpp f893067859425967654401f3226149268b51cf57 

Diff: https://reviews.apache.org/r/54062/diff/


Testing
-------

make check


Thanks,

Jay Guo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message