mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 54093: Refactored recordio::ReaderProcess to be managed by gc.
Date Sun, 27 Nov 2016 20:30:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54093/#review156973
-----------------------------------------------------------


Ship it!





src/common/recordio.hpp (line 107)
<https://reviews.apache.org/r/54093/#comment227350>

    You might want to commit naming the `ReaderProcess` as a separate commit since it's unrelated
to this patch.


- Anand Mazumdar


On Nov. 26, 2016, 5:40 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54093/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2016, 5:40 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This ensures that callers do not accidentally wait on the `read`
> future and end up waiting on ReaderProcess from within the context
> of the ReaderProcess.
> 
> 
> Diffs
> -----
> 
>   src/common/recordio.hpp cbd9d3667ba43eabb22c1af20853b8ed8e093852 
> 
> Diff: https://reviews.apache.org/r/54093/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message