mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 54039: Added `recordio::transform` helper.
Date Mon, 28 Nov 2016 06:48:46 GMT


> On Nov. 28, 2016, 3:23 a.m., Anand Mazumdar wrote:
> > src/common/recordio.hpp, line 112
> > <https://reviews.apache.org/r/54039/diff/3/?file=1570686#file1570686line112>
> >
> >     hmm, this doesn't need to be an `Owned` here. Can we just use `Reader<T>&&
reader` instead?
> >     
> >     We needed it to be an `Owned` in the scheduler library as we wanted to save
it as a member variable across invocations.

removing `Owned` didn't work because the destructor of `Reader` gets called a bunch of times
otherwise.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54039/#review156984
-----------------------------------------------------------


On Nov. 26, 2016, 5:41 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54039/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2016, 5:41 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6473
>     https://issues.apache.org/jira/browse/MESOS-6473
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This helper lets us transform raw bytes read from a RecordIO
> reader and write to a pipe.
> 
> 
> Diffs
> -----
> 
>   src/common/recordio.hpp cbd9d3667ba43eabb22c1af20853b8ed8e093852 
>   src/tests/common/recordio_tests.cpp 86a111724bd303bbb17b84d8b32b811476c66b57 
> 
> Diff: https://reviews.apache.org/r/54039/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message