mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 53458: Removed `Socket` dependency on `Socket::Impl`.
Date Mon, 28 Nov 2016 17:19:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53458/#review157065
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/src/poll_socket.cpp (line 117)
<https://reviews.apache.org/r/53458/#comment227470>

    Looks like we consistently use Socket::Impl in libevent_ssl_socket.cpp. Can we be consistent
and use Socket::Impl in this file as well?


- Jie Yu


On Nov. 28, 2016, 5:38 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53458/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2016, 5:38 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed `Socket` dependency on `Socket::Impl`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/socket.hpp f798af7879546d71e8ef4a295c9cf489a70cb61f

>   3rdparty/libprocess/src/libevent_ssl_socket.hpp acb00d41c637a318b2f16fff9e97998b9c79b809

>   3rdparty/libprocess/src/libevent_ssl_socket.cpp 5c0929d3d9f5595bd2f343b98b899fd6b06a67b2

>   3rdparty/libprocess/src/poll_socket.cpp eb7b48713edd30b545d7be95b5d51b0f71bd422a 
>   3rdparty/libprocess/src/socket.cpp 7f93168e1572f8669f67a4c5e6e5467259b7a407 
> 
> Diff: https://reviews.apache.org/r/53458/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message