mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 53961: CMake: Move test-specific variables into StoutTestsConfigure.
Date Mon, 28 Nov 2016 18:46:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53961/#review157077
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/cmake/StoutTestsConfigure.cmake (line 20)
<https://reviews.apache.org/r/53961/#comment227495>

    Super nit, and technically not your problem since you're moving this, but: I think this
line is over 80 characters?



3rdparty/stout/cmake/StoutTestsConfigure.cmake (line 44)
<https://reviews.apache.org/r/53961/#comment227497>

    Not your fault, but I believe this is not true with our current version of gtest. :)


- Alex Clemmer


On Nov. 21, 2016, 10:08 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53961/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2016, 10:08 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5792
>     https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These definitions were originally in:
> `3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake`
> 
> By consolidating these definitions in `StoutTestsConfigure`, we can
> reuse the same definitions for libprocess and Mesos tests as well.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/cmake/StoutTestsConfigure.cmake 2c786c53008d071a44137aa9507794e9860ed6b6

> 
> Diff: https://reviews.apache.org/r/53961/diff/
> 
> 
> Testing
> -------
> 
> See next review.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message