mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 53768: CMake Cleanup: Generate protobufs with fewer dependencies.
Date Mon, 28 Nov 2016 18:48:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53768/
-----------------------------------------------------------

(Updated Nov. 28, 2016, 10:48 a.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Changes
-------

Rebase on the hook protobuf addition.


Bugs: MESOS-5792
    https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
-------

The protobuf sub-library only actually requires the protobuf
dependencies in order to build.  Previously, it was dependent
on all of libprocess.


Diffs (updated)
-----

  cmake/MesosConfigure.cmake de04389b016b22bdff69e94d37fad4eedbda5874 
  src/CMakeLists.txt 9ff47d7a95c3baa5aa10039039e5ad065180ba45 

Diff: https://reviews.apache.org/r/53768/diff/


Testing
-------

cmake ..
make


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message