mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 53758: CMake: Added test sources to the build.
Date Mon, 28 Nov 2016 19:01:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53758/#review157106
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/CMakeLists.txt (line 79)
<https://reviews.apache.org/r/53758/#comment227522>

    Just so I'm clear about this: in other places, we're disabling source builds on WIN32
by `if`'ing out the source inclusion in the file, but here (because of legacy reasons) we're
depending on the "old way" of doing stuff, which is to `if` out the `add_subdirectory(tests/)`?
    
    If so, it would be nice to have a transition plan going in -- either one of us should
clean it up (either in this chain or after it), or we should file an issue, I think. Less
desirable would be to have two different conventions. _i.e._ I personally don't consider the
changes required to be a stop-ship, but I do consider having a plan to be a stop ship. :)


- Alex Clemmer


On Nov. 22, 2016, 8 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53758/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2016, 8 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5792
>     https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds most existing tests to the CMake build.  This excludes
> a few special cases, just as Java, Python, and network isolator
> tests.
> 
> This review replaces: https://reviews.apache.org/r/49921/
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 1362d65afc23816c34173866a3fdbce45936921d 
>   src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f 
>   src/tests/CMakeLists.txt 90b92251b7e133124f6d9a896190ceea402cbff1 
>   src/tests/cmake/MesosTestsConfigure.cmake 3f543c010ae87ff04e6b45745bc49ef65b6590ff

> 
> Diff: https://reviews.apache.org/r/53758/diff/
> 
> 
> Testing
> -------
> 
> cmake ..
> make
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message