mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 53762: CMake: Renamed MESOS_TARGET to MESOS_LIBS_TARGET.
Date Mon, 28 Nov 2016 19:06:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53762/#review157110
-----------------------------------------------------------


Ship it!




Ship It!

- Alex Clemmer


On Nov. 21, 2016, 10:15 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53762/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2016, 10:15 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5792
>     https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This purposefully excludes the dependency on `MESOS_TARGET` that
> exists in `MesosTestsConfigure.cmake`, as the tests require all
> of Mesos to be build first.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f 
>   src/cli/CMakeLists.txt c0120cd7f4ef8dc275edbd5cb1a4a6e23952ec63 
>   src/docker/CMakeLists.txt dca15dbf0679ae196b7a993f2e782ce2907c6750 
>   src/examples/CMakeLists.txt PRE-CREATION 
>   src/health-check/CMakeLists.txt ca577895411a13dcca27dbd67a63de831084ed37 
>   src/local/CMakeLists.txt 643a6cf653d91b8a606ac83b126dfd2245fa49bd 
>   src/log/CMakeLists.txt 8a92de4b0f9f69164930bd28c527f3a92ea0d17e 
>   src/master/CMakeLists.txt d9b4c170148daf041cb68fcebbc993abcde98acf 
>   src/slave/CMakeLists.txt 33120ace79bce449329a7cc4b7ef264d2867fc13 
>   src/slave/container_loggers/CMakeLists.txt PRE-CREATION 
>   src/slave/containerizer/mesos/CMakeLists.txt 8cb3507d4d250dee4ee2f1b324ac3fe945cf23c4

>   src/slave/qos_controllers/CMakeLists.txt 87c92af21c012655c201c01cd4ba5ff912555119 
>   src/slave/resource_estimators/CMakeLists.txt 17b149f734ea9dc8ac4c5dd45bdb8312faf4cc77

>   src/tests/cmake/MesosTestsConfigure.cmake 3f543c010ae87ff04e6b45745bc49ef65b6590ff

>   src/usage/CMakeLists.txt e5df5e74977ae085db85e35c67dedc974832496a 
> 
> Diff: https://reviews.apache.org/r/53762/diff/
> 
> 
> Testing
> -------
> 
> rm -rf build
> mkdir build
> cd build
> 
> cmake ..
> make
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message