mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 53759: CMake: Change libprocess to a shared library.
Date Mon, 28 Nov 2016 22:02:46 GMT


> On Nov. 17, 2016, 9:09 a.m., Alex Clemmer wrote:
> > 3rdparty/libprocess/src/CMakeLists.txt, line 93
> > <https://reviews.apache.org/r/53759/diff/1/?file=1563860#file1563860line93>
> >
> >     Seems like this should be using `MESOS_DEFAULT_LIBRARY_LINKAGE`?
> 
> Joseph Wu wrote:
>     Nope, Mesos variables shouldn't be used in stout/libprocess.
> 
> Alex Clemmer wrote:
>     Right. I suppose my real question is: should this be a variable of some sort? It
seems odd we'd use one elsewhere, but not for Stout.

For the 3rdparty libraries, libprocess is the only one where we explicitly control the linking
strategy.  (Stout is header-only and bundled dependencies have their own build systems.) 
I suppose the HTTP parser library also counts, but this one is also built as an external project,
meaning that CMake variables will not be inherited.

In the automake build, there is an option to build libprocess as a static library, but that
build path is untested (and completely broken :).  We can consider adding an equivalent variable
in future, but for now, it is safer not to.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53759/#review156214
-----------------------------------------------------------


On Nov. 14, 2016, 7:09 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53759/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2016, 7:09 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5792
>     https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In order to load modules that are themselves based on libprocess,
> we must link libprocess as a shared library.  Since modules are
> only supported on non-Windows platforms, this changes the default
> linking mode to SHARED on non-Windows.
> 
> This review replaces: https://reviews.apache.org/r/49924/
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/CMakeLists.txt d1547ef6a8762385f653d3824307727e4d0a7e71 
> 
> Diff: https://reviews.apache.org/r/53759/diff/
> 
> 
> Testing
> -------
> 
> cmake ..
> make
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message