mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 54099: Used environment to pass flags to launch helper.
Date Mon, 28 Nov 2016 22:39:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54099/#review157162
-----------------------------------------------------------




src/slave/containerizer/mesos/containerizer.cpp (lines 1548 - 1559)
<https://reviews.apache.org/r/54099/#comment227595>

    Hmm. As it is written, an environment variable set on the agent will override any environment
variables we set up via our launchFlags. Is this the intended behaviour?
    
    It seems like this could lead to unexpected consequences if (for example), we happen to
have `MESOS_CONTAINERIZER_USER=root` set when we launch our agent.


- Kevin Klues


On Nov. 27, 2016, 7:47 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54099/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2016, 7:47 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Kevin Klues.
> 
> 
> Bugs: MESOS-6648
>     https://issues.apache.org/jira/browse/MESOS-6648
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Instead of doing that just for command environment variables, this
> patch does it consistently by using environment variables to pass
> launch helper flags. This will be more secure.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 9b33495d9babc3ee489a8712fe1977746c41043f

> 
> Diff: https://reviews.apache.org/r/54099/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message