mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 53961: CMake: Move test-specific variables into StoutTestsConfigure.
Date Mon, 28 Nov 2016 23:26:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53961/
-----------------------------------------------------------

(Updated Nov. 28, 2016, 3:26 p.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Changes
-------

Rephrase a comment so that it fits under 80 characters.


Bugs: MESOS-5792
    https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description (updated)
-------

These definitions were originally in:
`3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake`

By consolidating these definitions in `StoutTestsConfigure`, we can
reuse the same definitions for libprocess and Mesos tests as well.

This also rephrases/reformats some of the moved comments to get 
them below 80 characters per line.


Diffs (updated)
-----

  3rdparty/stout/cmake/StoutTestsConfigure.cmake 2c786c53008d071a44137aa9507794e9860ed6b6


Diff: https://reviews.apache.org/r/53961/diff/


Testing
-------

See next review.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message