mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 53753: CMake: Added variable for default linking strategy.
Date Mon, 28 Nov 2016 23:27:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53753/
-----------------------------------------------------------

(Updated Nov. 28, 2016, 3:27 p.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Changes
-------

Bump minimum cmake version from 2.8 to 2.8.10


Bugs: MESOS-5792
    https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
-------

The `MESOS_DEFAULT_LIBRARY_LINKAGE` changes all Mesos libraries to
the use specified linking strategy (static or shared).  This does
not affect third-party libraries, which have their own requirements.

On Posix, the default is shared linkage.  On Windows the default
is static linkage.

This review replaces: https://reviews.apache.org/r/49862/


Diffs (updated)
-----

  3rdparty/CMakeLists.txt 092184bc4e27661dafc76788485f70584c870a28 
  CMakeLists.txt 1362d65afc23816c34173866a3fdbce45936921d 
  cmake/MesosConfigure.cmake de04389b016b22bdff69e94d37fad4eedbda5874 
  src/CMakeLists.txt 9ff47d7a95c3baa5aa10039039e5ad065180ba45 
  src/slave/qos_controllers/CMakeLists.txt 87c92af21c012655c201c01cd4ba5ff912555119 
  src/slave/resource_estimators/CMakeLists.txt 17b149f734ea9dc8ac4c5dd45bdb8312faf4cc77 

Diff: https://reviews.apache.org/r/53753/diff/


Testing
-------

cmake ..
make


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message