mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 56006: Added CHECK logging to the allocator.
Date Wed, 01 Feb 2017 21:03:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56006/#review163878
-----------------------------------------------------------


Ship it!





src/master/allocator/mesos/hierarchical.cpp (line 431)
<https://reviews.apache.org/r/56006/#comment235360>

    I think I asked why we couldn't use `CHECK_EQ` here in a previous review.


- Michael Park


On Jan. 26, 2017, 4:32 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56006/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2017, 4:32 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added CHECK logging to the allocator.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp c2211be7458755aeb91ef078e4bfe92ac474044a

> 
> Diff: https://reviews.apache.org/r/56006/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message