mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 56212: Added support for general checks to command executor.
Date Thu, 09 Feb 2017 11:23:12 GMT


> On Feb. 8, 2017, 1:32 a.m., Vinod Kone wrote:
> > src/launcher/executor.cpp, line 453
> > <https://reviews.apache.org/r/56212/diff/1/?file=1622062#file1622062line453>
> >
> >     there is a lot of code duplication in the call sites of checker and health checker
and their code itself. I know you had a TODO, but can you ensure there is a ticket for tracking
the de-duplication of code? we should tackle that sooner than latter, hopefully even before
1.3 is cut. otherwise it will be a nightmare to maintain both.

I could not agree more. https://issues.apache.org/jira/browse/MESOS-7092


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56212/#review164608
-----------------------------------------------------------


On Feb. 8, 2017, 4:56 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56212/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2017, 4:56 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Bugs: MESOS-6906
>     https://issues.apache.org/jira/browse/MESOS-6906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp d9417ce1d5b108f5292a66010eab80f11552a969 
> 
> Diff: https://reviews.apache.org/r/56212/diff/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/56218/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message