mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 56478: Renamed 'unsetAuthenticator' to 'unsetAuthenticators' in libprocess.
Date Thu, 09 Feb 2017 14:09:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56478/#review164920
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/include/process/http.hpp (line 80)
<https://reviews.apache.org/r/56478/#comment236749>

    s/authenticator/authenticators/



3rdparty/libprocess/src/authenticator_manager.hpp (line 50)
<https://reviews.apache.org/r/56478/#comment236748>

    s/authenticator/authenticators/


- Jan Schlicht


On Feb. 9, 2017, 7:10 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56478/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2017, 7:10 a.m.)
> 
> 
> Review request for mesos, Jan Schlicht and Vinod Kone.
> 
> 
> Bugs: MESOS-7004
>     https://issues.apache.org/jira/browse/MESOS-7004
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed 'unsetAuthenticator' to 'unsetAuthenticators' in libprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 3a406963c1defc037d58971f2400e40855503fbb

>   3rdparty/libprocess/src/authenticator_manager.hpp 0dc8fd24b411d649bcc62208bde5784cac4ea997

>   3rdparty/libprocess/src/authenticator_manager.cpp a22acd026a001788dc39b8005a56577e33c6800b

>   3rdparty/libprocess/src/process.cpp 3ad485f9136cd9edf0a6db76ff1f475039236391 
>   3rdparty/libprocess/src/tests/http_tests.cpp fb4da9aecff0370d97a15269c5d8fffb30e0478f

>   3rdparty/libprocess/src/tests/metrics_tests.cpp d7fdb06060b273e16be27a263b5ee268842aa25c

>   3rdparty/libprocess/src/tests/profiler_tests.cpp 995bd02f6ecce484cd9b2aca355c2707d73d40b2

> 
> Diff: https://reviews.apache.org/r/56478/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message