mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 56474: Added support for multiple authenticators to libprocess.
Date Thu, 09 Feb 2017 15:03:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56474/#review164924
-----------------------------------------------------------




3rdparty/libprocess/src/authenticator_manager.cpp (line 15)
<https://reviews.apache.org/r/56474/#comment236768>

    Also `#include <list>` because you're using `std::list` below.



3rdparty/libprocess/src/authenticator_manager.cpp (line 31)
<https://reviews.apache.org/r/56474/#comment236769>

    `using std::list;` above?



3rdparty/libprocess/src/authenticator_manager.cpp (line 160)
<https://reviews.apache.org/r/56474/#comment236767>

    Could also be `vector<AuthenticationResult> results(authenticators_[realm].size());`.
Of course, `combineFailedRequests` would need to be changed respectively.



3rdparty/libprocess/src/authenticator_manager.cpp (lines 168 - 204)
<https://reviews.apache.org/r/56474/#comment236756>

    How about we make this a function instead of using a lambda?
    Seems to do a lot and even contains another lambda in line 180.


- Jan Schlicht


On Feb. 9, 2017, 1:58 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56474/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2017, 1:58 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7004
>     https://issues.apache.org/jira/browse/MESOS-7004
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the `AuthenticatorManager` to allow
> multiple authenticators to be set for a single realm.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/authenticator_manager.cpp a22acd026a001788dc39b8005a56577e33c6800b

> 
> Diff: https://reviews.apache.org/r/56474/diff/
> 
> 
> Testing
> -------
> 
> Testing information can be found in the subsequent patch in this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message