mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 53993: Updated quota doc to support quota update.
Date Thu, 09 Feb 2017 17:41:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53993/#review164947
-----------------------------------------------------------




docs/quota.md (line 159)
<https://reviews.apache.org/r/53993/#comment236784>

    "The syntax for update requests is identical to the syntax for [set requests](#setRequest)".
    
    Note the typo in spelling of "identical".



docs/quota.md (line 168)
<https://reviews.apache.org/r/53993/#comment236785>

    Comma after "check" -- can you change this for "set" as well above?



docs/quota.md (line 180)
<https://reviews.apache.org/r/53993/#comment236786>

    "(e.g., the role does not exist, the role exists but does not have quota already set,
invalid JSON, non-scalar resources included)"



docs/quota.md (line 342)
<https://reviews.apache.org/r/53993/#comment236787>

    "Rescind at least as many resources as are required to satisfy the quota request"


- Neil Conway


On Feb. 9, 2017, 5:29 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53993/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2017, 5:29 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Xiaojian Huang, and Neil Conway.
> 
> 
> Bugs: MESOS-4941
>     https://issues.apache.org/jira/browse/MESOS-4941
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated quota doc to support quota update.
> 
> 
> Diffs
> -----
> 
>   docs/quota.md 36b4853b524ba7b28788fe1f3983dd43d95072d4 
> 
> Diff: https://reviews.apache.org/r/53993/diff/
> 
> 
> Testing
> -------
> 
> https://github.com/zhitaoli/mesos/blob/quota_update_sept/docs/quota.md
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message